ai: draft consumer facing ATS skill (do not merge) - #1472
Draft
Lena Forlin (moshimorschi) wants to merge 1 commit into
Draft
ai: draft consumer facing ATS skill (do not merge)#1472Lena Forlin (moshimorschi) wants to merge 1 commit into
Lena Forlin (moshimorschi) wants to merge 1 commit into
Conversation
Draft skill for projects that consume @shopware-ag/acceptance-test-suite as a package: workspace setup, writing specs, test data, accessibility via the bundled axe task, and troubleshooting. Validated against a shop created with shopware-cli project create --docker. Kept in skills-drafts so the skills CI does not treat it as a published Shopware CLI skill.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
+ Coverage 61.97% 61.99% +0.02%
==========================================
Files 427 427
Lines 28991 28991
==========================================
+ Hits 17966 17973 +7
+ Misses 11025 11018 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
15 tasks
15 tasks
Lena Forlin (moshimorschi)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skills-drafts/acceptance-test-suite/SKILL.mdis a draft consumer facing ATS skill: workspace setup, writing specs, test data, accessibility, troubleshooting.After trial and error, one experiment was a success. I created a shop with
shopware-cli project create --docker, followed the skill's own code blocks verbatim, and ran real tests against it. A functional spec, an accessibility spec and an actor pattern spec all pass,tscis clean, and a clean room rebuild needs no manual steps. That covers the "validated by writing and running real tests" criterion from the issue.Where it should live: the ATS repo, at
skills/acceptance-test-suite/SKILL.md, released from the package tags so it cannot drift from the code it describes. Nothing in the file is CLI specific, so moving it is a copy. No CLI wiring in this PR, that follows separately.Ownership: I still want to discuss this but am happy to take full ownership here for maintaining at ATS as well.
The skill sits in
skills-drafts/so the skills CI does not treat it as a published Shopware CLI skill.Refs #1465