Body:
The ShrimpyApiClient class uses two different methods for constructing query strings: directly in the get_orderbooks function, and using the helper function _create_query_string elsewhere. This inconsistency can lead to confusion and potential errors. Furthermore, get_orderbooks unnecessarily defines endpoint inline when it could reuse the class's _create_query_string function to centralize query parameter handling.
Recommendation:
- Standardize the query string construction process. Use the
_create_query_string method consistently across all API calls.
- Refactor
get_orderbooks to use _create_query_string and extract the endpoint into a variable.
Body:
The
ShrimpyApiClientclass uses two different methods for constructing query strings: directly in theget_orderbooksfunction, and using the helper function_create_query_stringelsewhere. This inconsistency can lead to confusion and potential errors. Furthermore,get_orderbooksunnecessarily defines endpoint inline when it could reuse the class's_create_query_stringfunction to centralize query parameter handling.Recommendation:
_create_query_stringmethod consistently across all API calls.get_orderbooksto use_create_query_stringand extract the endpoint into a variable.