storage(feat): adding support for signed url for workload identity - #68
Open
shubhangi-google wants to merge 2 commits into
Open
storage(feat): adding support for signed url for workload identity#68shubhangi-google wants to merge 2 commits into
shubhangi-google wants to merge 2 commits into
Conversation
shubhangi-google
requested review from
gurusai-voleti,
mahendra-google and
thiyaguk09
August 25, 2026 12:02
shubhangi-google
changed the title
| end | ||
| unencoded_signature = signing_key.sign OpenSSL::Digest::SHA256.new, secret | ||
| elsif Google::Cloud.env.compute_engine? | ||
| require "google/cloud/storage/iam_signer" |
Collaborator
There was a problem hiding this comment.
can you make this a class level variable, is it possible?
| issuer = options[:issuer] || options[:client_email] || @service.credentials.issuer | ||
| return issuer if issuer | ||
|
|
||
| if Google::Cloud.env.compute_engine? |
Collaborator
There was a problem hiding this comment.
does this making compute engine a mandatory for this authentication
| signer = service_account_signer signing_key | ||
| elsif Google::Cloud.env.compute_engine? | ||
| require "google/cloud/storage/iam_signer" | ||
| iam_signer = Google::Cloud::Storage::IAMSigner.new |
| packed_signature = signing_key.sign OpenSSL::Digest::SHA256.new, data | ||
| elsif Google::Cloud.env.compute_engine? | ||
| require "google/cloud/storage/iam_signer" | ||
| iam_signer = Google::Cloud::Storage::IAMSigner.new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
bundle exec rake ciin the gem subdirectory.closes: #<issue_number_goes_here>