LT-22652: Automatically update strings in Crowdin - #1046
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
=========================================
+ Coverage 0 38.07% +38.07%
=========================================
Files 0 1499 +1499
Lines 0 350146 +350146
Branches 0 40239 +40239
=========================================
+ Hits 0 133307 +133307
- Misses 0 187560 +187560
- Partials 0 29279 +29279 🚀 New features to boost your workflow:
|
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on papeh).
.github/workflows/patch-installer-cd.yml line 119 at r1 (raw file):
ref: ${{ github.event.inputs.lcm_ref || 'master' }} fetch-depth: 0 path: 'Localizations/LCM'
In the workflow we decided to clone LCM into the Localizations folder (since that is the only reason we needed it) devin caught that the uploadUpdatesForTranslation task deletes that folder. Doing this before the build will make the localization build fail, it could be done at the end though.
|
I thought Devin was being silly. Silly me. Unfortunately, deleting the actual LCM repo at the beginning of CopyLcmResxFiles will also prevent these strings from being uploaded. The uploadUpdatesForTranslation and Localize targets expect a different directory structure in LCM, so we'll have to rename one. Renaming the destination of CopyLcmResxFiles would break our structure in Crowdin, so we have to move the repository. We could call it liblcm or lcmrepo. We want to upload sources before the build so that, if any strings have breaking changes, the build still succeeds the first time. |
|
Devin suggests I think a l10n upload error should automatically fail the build (or at least warn): we want to know when the upload fails; moreover, many upload failures would result in the entire build failing anyway (CrowdIn outage, bad API key) |
f6c3f26 to
5eb6a9c
Compare
NUnit Tests 1 files 1 suites 11m 17s ⏱️ Results for commit e163473. ♻️ This comment has been updated with latest results. |
Update Crowdin source strings as soon as they are updated in FLEx. Doing so requires Crowdin access, and developers frequently forget. FUTURE WORK: automate list export
and build Release (not that it matters, but it looks consistent)
In case strings diverge and we don't remember to remove the branch from crowdin.json when creating a branch for a patch on stable. This will prevent stable strings overwriting latest strings.
to distinguish the entire repo from localizable files copied from it
It is possible that Crowdin has made their uploads finicky; this should not fail the whole build, but we need to know.
7c61068 to
4921901
Compare
Update Crowdin source strings as soon as they are updated in FLEx. Doing so requires Crowdin access, and developers frequently forget.
FUTURE WORK: automate list export
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).This change is