Export Get-VsToolchainInfo so installer and patch builds run - #1072
Merged
Conversation
build.ps1 imports only FwBuildHelpers.psm1, which imports FwBuildEnvironment.psm1 privately and re-exports a whitelist of its functions. Get-VsToolchainInfo was missing from that whitelist, so the toolset warning added in #1067 failed with "The term 'Get-VsToolchainInfo' is not recognized". CI never caught it because the only call site sits behind the -BuildInstaller/-BuildPatch guard, which CI.yml does not exercise. Also export Get-CvtresDiagnostics from FwBuildEnvironment.psm1. FwBuildHelpers already lists it for re-export, but the inner module never exported it, so the name silently resolved to nothing and the next caller from build.ps1 would have hit the same failure. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
papeh
approved these changes
Aug 17, 2026
thejambi
marked this pull request as ready for review
August 17, 2026 21:04
NUnit Tests 1 files 1 suites 9m 5s ⏱️ Results for commit 5a3e1ab. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
+ Coverage 38.04% 38.07% +0.02%
==========================================
Files 1499 1499
Lines 350127 350146 +19
Branches 40239 40239
==========================================
+ Hits 133215 133307 +92
+ Misses 187625 187560 -65
+ Partials 29287 29279 -8 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Summary
build.ps1 imports only FwBuildHelpers.psm1, which imports FwBuildEnvironment.psm1 privately and re-exports a whitelist of its functions. Get-VsToolchainInfo was missing from that whitelist, so the toolset warning added in #1067 failed with "The term 'Get-VsToolchainInfo' is not recognized". CI never caught it because the only call site sits behind the -BuildInstaller/-BuildPatch guard, which CI.yml does not exercise.
Also export Get-CvtresDiagnostics from FwBuildEnvironment.psm1. FwBuildHelpers already lists it for re-export, but the inner module never exported it, so the name silently resolved to nothing and the next caller from build.ps1 would have hit the same failure.
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).build.ps1/test.ps1or MSBuild).Docs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.Notes for reviewers (optional)
This change is