Skip to content

Randomize GITHUB_ENV delimiter in commit-message check #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
papeh merged 1 commit into from
Aug 17, 2026
Merged

Randomize GITHUB_ENV delimiter in commit-message check #1073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/CommitMessage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,14 @@ jobs:
Set-Content -Path check_results.log -Value $log -NoNewline
# Put the results into the job summary
Add-Content -Path $env:GITHUB_STEP_SUMMARY -Value $log
# Put the results into a multi-line environment variable to use in the next step
Add-Content -Path $env:GITHUB_ENV -Value 'check_results<<###LINT_DELIMITER###'
# Put the results into a multi-line environment variable to use in the next step.
# $log echoes the PR's own commit messages, so a static heredoc marker could be
# reproduced in a commit to close the block early and inject arbitrary variables.
# A random per-run delimiter cannot be known in advance, so the content is inert.
$delimiter = "LINT_EOF_$([guid]::NewGuid().ToString('N'))"
Add-Content -Path $env:GITHUB_ENV -Value "check_results<<$delimiter"
Add-Content -Path $env:GITHUB_ENV -Value $log
Add-Content -Path $env:GITHUB_ENV -Value '###LINT_DELIMITER###'
Add-Content -Path $env:GITHUB_ENV -Value $delimiter
# add a comment on the PR if the commit message linting failed
- name: Comment on PR
if: failure()
Expand Down
Loading