Skip to content

Handle overflow errors in date conversion recipes #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RamiNoodle733 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle overflow errors in date conversion recipes #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
974ac5c
Handle date parser overflow errors
RamiNoodle733 Sep 13, 2026
9e64607
Add regression tests for date parser overflow
RamiNoodle733 Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sqlite_utils/recipes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def parsedate(
.date()
.isoformat()
)
except parser.ParserError:
except (parser.ParserError, OverflowError):
if errors is IGNORE:
return value
elif errors is SET_NULL:
Expand All @@ -58,7 +58,7 @@ def parsedatetime(
return value
try:
return parser.parse(value, dayfirst=dayfirst, yearfirst=yearfirst).isoformat()
except parser.ParserError:
except (parser.ParserError, OverflowError):
if errors is IGNORE:
return value
elif errors is SET_NULL:
Expand Down
24 changes: 24 additions & 0 deletions tests/test_recipe_overflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import pytest

from sqlite_utils import recipes


OVERFLOWING_DATE = "999999999999999999999999999999-01-01"


@pytest.mark.parametrize("fn", ("parsedate", "parsedatetime"))
def test_dateparse_overflow_raises_by_default(fn):
with pytest.raises(OverflowError):
getattr(recipes, fn)(OVERFLOWING_DATE)


@pytest.mark.parametrize("fn", ("parsedate", "parsedatetime"))
@pytest.mark.parametrize(
"errors,expected",
(
(recipes.IGNORE, OVERFLOWING_DATE),
(recipes.SET_NULL, None),
),
)
def test_dateparse_overflow_respects_errors(fn, errors, expected):
assert getattr(recipes, fn)(OVERFLOWING_DATE, errors=errors) == expected
Loading