fix resolver v2 for subnames - #1867
Merged
Merged
Conversation
epoberezkin
marked this pull request as ready for review
September 11, 2026 15:09
epoberezkin
requested review from
epoberezkin and
spaced4ndy
as code owners
September 11, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
sub.brenzi.testingwhich doesn't exist resolved tobrenzi.testingwhich is not a legit fallback, although availability goes by 2LDThis PR fixes it for v2 (wording fix is in simplex-chat/simplex-chat@c4b2b75):
sub.simplex.testing not registered; simplex.testing is reserved for SimpleX
sub.brenzi.testing not registered; subnames are created by the owner of brenzi.testing
sub.ghostname9x.testing not registered; subnames are created by the owner of ghostname9x.testing
simplex.testing reserved for SimpleX (2LD unaffected)
testing.kingofthebongo.testing registered, expires 2027-06-25, … (existing subname unaffected)