Disambiguate IPv6 host:port pairs with universal bracketing - #1870
Open
spencer-michaels-1pw wants to merge 3 commits into
Open
Disambiguate IPv6 host:port pairs with universal bracketing#1870spencer-michaels-1pw wants to merge 3 commits into
spencer-michaels-1pw wants to merge 3 commits into
Conversation
spencer-michaels-1pw
requested review from
epoberezkin and
spaced4ndy
as code owners
September 12, 2026 06:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1807 added support for reading bracketed IPv6 addresses, but left behind several cases in which
simplexmqitself still generates bracket-less addresses that parse ambiguously when passed back intosimplexmqif they explicitly specify a port. As a result, reading a saved IPv6 address or opening an invitation or web link to an IPv6 host can result insimplexmqerroneously reading the port as part of the address.This PR adds brackets around IPv6 addresses generated as part of server addresses, remote-control invitations, connection links, and XFTP web links. Brackets are added even when no explicit port is written, keeping the address unambiguous.
For backwards compatibility, I erred on the side of still parsing older bracketless saved/linked IPv6 addresses as before, rather than refusing to parse them outright since they are inherently ambiguous.
Tests added/updated