Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| def _close(writer: asyncio.StreamWriter) -> None: | ||
| try: | ||
| writer.close() | ||
| except OSError: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mxsrc
force-pushed
the
fastapi-spdk-proxy
branch
4 times, most recently
from
September 7, 2026 19:07
2154d5d to
6e60e9e
Compare
mxsrc
force-pushed
the
fastapi-spdk-proxy
branch
from
September 7, 2026 20:21
819f664 to
858fa10
Compare
The existing proxy executed at import time and utilized global state, making it difficult to reason about. Converting this to FastAPI addresses this issue, aligns the proxy with the other API code, and enables simpler integration of richer SPDK-side interaction.
These broke tests that executed later and relied on sleep behaving as intended.
The pyupgrade ruleset landed on main while this branch rewrote the proxy, so the rewritten files never went through it. rpc_client additionally lost the `typing.Optional` import upstream while this branch added a new `Optional[SecretStr]` annotation, leaving an undefined name at import time. Claude-Session: https://claude.ai/code/session_014BUR7tZ9uyss93sLwKb6gz
mxsrc
force-pushed
the
fastapi-spdk-proxy
branch
from
September 14, 2026 11:13
858fa10 to
43f0fcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing proxy executed at import time and utilized global state, making it difficult to reason about. Converting this to FastAPI addresses this issue, aligns the proxy with the other API code, and enables simpler integration of richer SPDK-side interaction.