-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Pi: You are a senior software engineer working in the Sim codebase (sims... #6018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "\"pi/oI1D29Gs\""
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,6 +116,8 @@ export const Panel = memo(function Panel() { | |
| const router = useRouter() | ||
| const params = useParams() | ||
| const workspaceId = params.workspaceId as string | ||
| const workflowId = params.workflowId as string | ||
| const copilotDraftScopeKey = `${workspaceId}:copilot:${workflowId}` | ||
|
|
||
| const posthog = usePostHog() | ||
| const posthogRef = useRef(posthog) | ||
|
|
@@ -898,6 +900,7 @@ export const Panel = memo(function Panel() { | |
| onCancelQueueEdit={copilotCancelQueueEdit} | ||
| userId={session?.user?.id} | ||
| chatId={copilotResolvedChatId} | ||
| draftScopeKey={copilotDraftScopeKey} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stale draft on workflow changeMedium Severity When navigating between workflows, the Reviewed by Cursor Bugbot for commit 0e77e00. Configure here. |
||
| layout='copilot-view' | ||
| /> | ||
| </div> | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL id mismatches active workflow
Medium Severity
The
copilotDraftScopeKeyis built fromparams.workflowId, but the Copilot chat session and related hooks rely onactiveWorkflowIdfrom the workflow registry. This mismatch can cause drafts to be scoped to a different workflow than the active Copilot session, particularly during navigation or hydration.Reviewed by Cursor Bugbot for commit 0e77e00. Configure here.