fix(connectors): attribute SharePoint not-found errors to the matched library

[waleedlatif1]

Summary

Follow-up to #6026, fixing a Cursor Bugbot finding that was reported before that PR merged but landed unfixed.

• When the first path segment named a real non-default document library but the remainder did not resolve there, buildFolderNotFoundMessage described a search of the default library over the full original path
• It also advised stripping a leading Documents / Shared Documents prefix — actively wrong when the user had correctly supplied a library name
• Now reports against the library that was matched, over the remainder actually searched, and only offers the prefix hint when the default library really was the one searched

Concretely: Policies/HR, where Policies is a real library and HR is not in it, previously reported document library "Documents" and path "Policies/HR" and listed the wrong library's folders. It now names Policies, the path HR, and lists that library's folders.

Diagnostics only — no change to which folder resolves.

Type of Change

• Bug fix

Testing

Added a regression test asserting the message names the matched library, its remainder, and its folder names, and contains neither the default library name nor the prefix hint. 23 connector tests pass; typecheck and lint clean.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 28, 2026 11:43pm

[cursor]

PR Summary

Low Risk
Diagnostics-only change in the SharePoint connector; folder resolution logic is untouched.

Overview
Fixes misleading SharePoint folder-not-found diagnostics when the first path segment matches a non-default document library but the rest of the path does not resolve there. Resolution behavior is unchanged; only error text and which library’s folders are listed.

resolveFolderTarget now builds the failure from the matched library and its remainder (Policies + HR for Policies/HR), instead of the default library and the full path. buildFolderNotFoundMessage takes a searchedDefaultLibrary flag so the “omit Documents / Shared Documents prefix” hint appears only when the default library was actually searched.

Regression tests cover the matched-library case and confirm the prefix hint still appears for paths like Shared Documents/Reports.

^{Reviewed by Cursor Bugbot for commit 01a136d. Configure here.}

[greptile-apps]

Greptile Summary

Fixes SharePoint folder not-found diagnostics so they attribute the matched library and remainder path, and only suggest stripping a Documents/Shared Documents prefix when the default library was actually searched.

• resolveFolderTarget reports against libraryMatch (or the default drive) with the segments that were searched
• buildFolderNotFoundMessage takes searchedDefaultLibrary to gate the prefix hint
• Regression tests cover matched-library blame and retained default-library prefix advice

Confidence Score: 5/5

This PR appears safe to merge; no blocking failures remain from the current change set or prior review findings available in this session.

No blocking failure remains. The update only corrects diagnostic attribution and when the prefix-stripping hint is shown; resolution behavior is unchanged and covered by new tests.

Important Files Changed

Filename	Overview
apps/sim/connectors/sharepoint/sharepoint.ts	Attributes not-found errors to the matched library and remainder path; gates the Documents/Shared Documents prefix hint on default-library search.
apps/sim/connectors/sharepoint/sharepoint.test.ts	Adds regression coverage for matched-library blame and default-library prefix-hint behavior.

_{Reviews (2): Last reviewed commit: "fix(connectors): key the library-prefix ..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 01a136d. Configure here.}