Skip to content

fix(search): harden connector setup and indexed access - #7710

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-end-to-end-qa
Sep 10, 2026
Merged

fix(search): harden connector setup and indexed access#7710
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-end-to-end-qa

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix organization-scoped credential setup, managed-account browsing and provider-specific read scopes while keeping central indexing service-account-only.
  • Correct connector pagination, permissions, Gmail body hydration and sync removal reporting; preserve staging's existing indexing safeguards.
  • Align Search citations, source settings, sync history and MCP onboarding with existing UI patterns.
  • Update Search setup guides, screenshots and MCP documentation to describe the supported paths and limitations.

Type of Change

  • Bug fix

Testing

  • 154 Vitest suites / 3,007 tests and 18 real PostgreSQL suites / 168 tests passed. Follow-up changes passed 89 setup tests and 167 Gmail/persistence tests, including oversized responses, revision races and unchanged-skip handling.
  • Real Google and Atlassian setup, indexing, Search, assistant and MCP checks, including edits, deletion and selected permission transitions. Provider variants and production-scale workloads are not exhaustively certified.
  • Repository lint, all 26 workspace type checks, all 46 repository audits and generated documentation checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 10, 2026 2:53am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile-apps Please review this PR.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The updated PR appears safe to merge, with the prior Gmail oversized-thread finding resolved and no new actionable failures identified.

Summary

  • Brackets one bounded full-thread retry with minimal revision reads.
  • Replaces stale indexed content when a stable oversized revision is confirmed.
  • Reconsiders skipped threads after their Gmail revision changes.
  • Adds regression coverage for declared and streamed overflows, revision races, transient failures, member isolation, and later recovery.
  • Updates Gmail Search documentation to describe size-limit behavior.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Fetch full Gmail thread] -->|Success| B[Format and index thread]
  A -->|Confirmed size overflow| C[Read minimal revision]
  C --> D[Retry full thread once]
  D -->|Success| B
  D -->|Confirmed size overflow| E[Read minimal revision again]
  E -->|Revision changed| F[Return transient error]
  E -->|Revision stable| G[Persist size-limit skip and remove stale content]
  G --> H[Future listing]
  H -->|Same revision| I[Keep stable skip]
  H -->|Changed revision| A
Loading

Reviews (2) · Last reviewed commit: "fix(search): persist verified Gmail size..."

Comment thread apps/sim/connectors/gmail/gmail.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile-apps Please review the updated PR.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit fbb5c70 into staging Sep 10, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-end-to-end-qa branch September 10, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant