-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(function): add local data conversion APIs #7727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
waleedlatif1
wants to merge
2
commits into
staging
Choose a base branch
from
codex/function-data-globals
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /** | ||
| * @vitest-environment node | ||
| * | ||
| * Exercises the actual worker with SIM_HELPERS_SMOKE=1 and a compatible Node build. | ||
| */ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { executeInIsolatedVM } from '@/lib/execution/isolated-vm' | ||
|
|
||
| function run(code: string, timeoutMs = 5000) { | ||
| return executeInIsolatedVM({ | ||
| code, | ||
| params: {}, | ||
| envVars: {}, | ||
| contextVariables: {}, | ||
| timeoutMs, | ||
| requestId: 'function-globals-smoke', | ||
| }) | ||
| } | ||
|
|
||
| describe.skipIf(process.env.SIM_HELPERS_SMOKE !== '1')('Function globals in a real isolate', () => { | ||
| it('uses Buffer and text codecs without imports or a remote sandbox', async () => { | ||
| const result = await run(` | ||
| const payload = { text: 'Hello 🌍' } | ||
| const encoded = Buffer.from(JSON.stringify(payload), 'utf8').toString('base64') | ||
| const decoded = new TextDecoder().decode(new TextEncoder().encode(payload.text)) | ||
| return { encoded, decoded, binary: atob(btoa('hello')), zero: Buffer.allocUnsafe(32).every(b => b === 0) } | ||
| `) | ||
| expect(result.error).toBeUndefined() | ||
| expect(result.result).toEqual({ | ||
| encoded: Buffer.from(JSON.stringify({ text: 'Hello 🌍' }), 'utf8').toString('base64'), | ||
| decoded: 'Hello 🌍', | ||
| binary: 'hello', | ||
| zero: true, | ||
| }) | ||
| }) | ||
|
|
||
| it('keeps prototypes and host capabilities isolated between executions', async () => { | ||
| const first = await run(` | ||
| Buffer.prototype.polluted = true | ||
| TextEncoder.prototype.polluted = true | ||
| return Buffer.from.constructor('return typeof process + ":" + typeof require')() | ||
| `) | ||
| expect(first.error).toBeUndefined() | ||
| expect(first.result).toBe('undefined:undefined') | ||
| const next = await run( | ||
| 'return [Buffer.prototype.polluted === undefined, TextEncoder.prototype.polluted === undefined]' | ||
| ) | ||
| expect(next.error).toBeUndefined() | ||
| expect(next.result).toEqual([true, true]) | ||
| }) | ||
|
|
||
| it('preserves user-code error locations and catches invalid conversions', async () => { | ||
| const result = await run("const data = Buffer.from('hello')\nthrow new Error('expected error')") | ||
| expect(result.error).toMatchObject({ | ||
| line: 2, | ||
| lineContent: "throw new Error('expected error')", | ||
| }) | ||
| const caught = await run("try { btoa('🌍'); return false } catch { return true }") | ||
| expect(caught.error).toBeUndefined() | ||
| expect(caught.result).toBe(true) | ||
| }) | ||
|
|
||
| it('retains timeout enforcement and allows subsequent executions', async () => { | ||
| const result = await run('while (true) { new TextEncoder().encode("hello") }', 100) | ||
| expect(result.error).toBeDefined() | ||
| expect(result.termination).toBe('timeout') | ||
| const next = await run('return Buffer.from("ok").toString()') | ||
| expect(next.error).toBeUndefined() | ||
| expect(next.result).toBe('ok') | ||
| }) | ||
|
|
||
| it('charges Buffer allocations to the existing isolate memory limit', async () => { | ||
| const result = await run( | ||
| 'const buffers = []; while (true) { buffers.push(Buffer.alloc(16 * 1024 * 1024)) }' | ||
| ) | ||
| expect(result.error).toBeDefined() | ||
| expect(result.error?.message).toMatch( | ||
| /memory|disposed|cancelled|Array buffer allocation failed/i | ||
| ) | ||
| const next = await run('return Buffer.alloc(4).length') | ||
| expect(next.error).toBeUndefined() | ||
| expect(next.result).toBe(4) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
19 changes: 19 additions & 0 deletions
19
apps/sim/lib/execution/sandbox/bundles/function-globals.cjs
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.