fix(realtime): ignore object key order in search replacements - #7769
Draft
j15z wants to merge 1 commit into
Draft
Conversation
10 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compare the current subblock value with the planned search replacement using structural equality. JSONB key ordering no longer causes a false conflict; changed values and reordered arrays still conflict.
Stack 3/7. Merge after #7768. Feature: #7538.
Type of Change
Testing
Three regression tests pass: equivalent nested objects with reordered keys, a changed tool parameter, and a reordered tool array. The full realtime suite also passes on the assembled stack.
Checklist
Screenshots/Videos
Not applicable.