Update to mizer's new simpler S3 extension mechanism - #6
Open
gustavdelius wants to merge 1 commit into
Open
Conversation
- Remove obsolete .onLoad session registration (registerExtension, makeActiveBinding) - Adopt S3 extension classes and coerceToExtensionClass / recordExtension workflow - Upgrade bundled NWMed_params dataset to an S3 object - Update tests to use expect_s3_class instead of expect_s4_class - Update documentation and vignettes for S3 extension mechanism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updates
mizerShelfto work with mizer's new simpler S3 extension mechanism:Remove obsolete session registration:
.onLoad()inR/mizerShelf-package.R(registerExtension()andmakeActiveBinding()are no longer needed).methodsdependency fromDESCRIPTIONandR/plots.R(is()->inherits()).Adopt S3 extension classes and tracking:
newDetritusCarrionParams()inR/newDetritusCarrionParams.Rto callrecordExtension(params, "mizerShelf", version = ..., requirement = "sizespectrum/mizerShelf")andcoerceToExtensionClass(params).R/mizerShelf-class.RandR/data.Rto describe S3 extension classes (c("mizerShelf", "MizerParams")/c("mizerShelfSim", "MizerSim")) and standard lazy-loading.Migrate bundled dataset:
data/NWMed_params.rdato an S3MizerParamsobject with extension metadata and class vectorc("mizerShelf", "MizerParams").Update tests and vignettes:
expect_s4_class()withexpect_s3_class()across test files intests/testthat/.vignettes/extension_mechanism.Rmdto explain S3 extension classes and coercion.vignettes/explore_scenarios.RmdandNEWS.md.R CMD checkruns cleanly.