fix: print shorter violations table [DX-5147] - #2812
Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
There was a problem hiding this comment.
🟡 Changes recommended
Address the two moderate table rendering and grouping issues before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR shortens the human-readable violations table by grouping identical rows and displaying counts.
Changes:
- Groups matching violations.
- Updates CLI documentation and tests.
- Adds a changeset entry.
Two moderate issues remain in the grouping and count rendering logic.
File summaries
| File | Summary |
|---|---|
grafana-alertcheck/docs/reference/cli.md |
Documents the grouped table format. |
grafana-alertcheck/cmd/table.go |
Groups and counts violations; requires fixes for synthetic-instance labeling and incomplete sorting keys. |
grafana-alertcheck/cmd/table_test.go |
Tests grouped output. |
grafana-alertcheck/.changeset/v0.1.1.md |
Records the release summary. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
42bfe4e to
f0a895f
Compare
No description provided.