Preserve streaming body terminal errors - #116
Open
samuel-williams-shopify wants to merge 1 commit into
Open
Conversation
samuel-williams-shopify
force-pushed
the
body-terminal-semantics
branch
from
August 6, 2026 09:54
b21b9b2 to
c4d6323
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IO#closezero-argument while using an explicitclose_with_error(error)capability for error-aware body streamsThis establishes the transport-neutral body semantics needed to distinguish HTTP/2 END_STREAM completion from RST_STREAM cancellation in HTTP/1 <-> HTTP/2 proxies. The explicit error-close capability avoids method-arity probing and prevents a streaming failure from being translated into a clean HTTP/2 END_STREAM.
Testing