Skip to content

impr: Pass state takes precedence over pipeline-held state - #2987

Draft
reczkok wants to merge 1 commit into
mainfrom
feat/pass-state-precedence
Draft

reczkok wants to merge 1 commit into
mainfrom
feat/pass-state-precedence

Conversation

@reczkok

@reczkok reczkok commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

pass.set* > pipeline.with* > WebGPU default (.with is per pipeline, does not influence other pipelines)

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@caa75222fe1df25c96fa369bb190ab082bdbc963
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/cli@caa75222fe1df25c96fa369bb190ab082bdbc963
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/gl@caa75222fe1df25c96fa369bb190ab082bdbc963

benchmark
view benchmark

commit
view commit

@reczkok
reczkok force-pushed the feat/pass-state-precedence branch 2 times, most recently from f6969e9 to 4fcc8b8 Compare September 7, 2026 15:21
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Bundle size comparison (import * as ... in PR vs import * as ... in target):

🟢 Decreased (max -0.10%) ➖ Unchanged 🔴 Increased ❔ Unknown
4 321 0 0

No notable changes.

If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Resolution Time Benchmark

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [1.04, 2.00, 4.61, 6.82, 7.78, 12.78, 25.54, 27.30]
  line [1.08, 2.09, 4.82, 7.04, 7.86, 12.99, 24.46, 28.50]
  line [1.02, 2.16, 4.76, 6.49, 7.78, 13.26, 24.79, 25.52]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.36, 0.57, 0.77, 0.91, 1.11, 1.20, 1.41, 1.61]
  line [0.31, 0.52, 0.74, 0.93, 1.21, 1.28, 1.52, 1.65]
  line [0.34, 0.54, 0.69, 0.87, 1.16, 1.29, 1.46, 1.64]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.98, 2.39, 3.83, 7.30, 12.82, 26.86, 59.45, 119.29]
  line [0.98, 2.43, 3.85, 7.50, 13.09, 27.21, 58.39, 118.41]
  line [0.94, 2.27, 4.73, 8.68, 13.66, 27.86, 57.34, 118.39]
Loading

@reczkok
reczkok force-pushed the feat/pass-state-precedence branch from 4fcc8b8 to caa7522 Compare September 8, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant