Skip to content

chore: Update table style to match new example page - #3004

Open
cieplypolar wants to merge 8 commits into
releasefrom
impr/cpugpu-example-new-layout
Open

cieplypolar wants to merge 8 commits into
releasefrom
impr/cpugpu-example-new-layout

Conversation

@cieplypolar

@cieplypolar cieplypolar commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

pkg.pr.new

No packages changed since release

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Resolution Time Benchmark

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.61, 1.19, 2.36, 3.99, 4.69, 6.93, 12.99, 14.26]
  line [0.62, 1.23, 2.42, 3.62, 4.64, 7.81, 13.74, 14.58]
  line [0.57, 1.10, 2.49, 3.39, 3.96, 7.33, 13.40, 14.80]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.18, 0.31, 0.44, 0.51, 0.72, 0.74, 0.89, 0.99]
  line [0.19, 0.36, 0.45, 0.52, 0.70, 0.72, 0.85, 1.00]
  line [0.18, 0.38, 0.47, 0.56, 0.67, 0.69, 0.81, 0.87]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.78, 1.58, 2.30, 4.32, 7.37, 14.75, 32.04, 69.75]
  line [0.56, 1.32, 2.27, 4.44, 6.71, 14.65, 32.79, 66.13]
  line [0.54, 1.48, 2.07, 4.30, 6.92, 15.04, 32.14, 65.87]
Loading

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Bundle size comparison (import * as ... in PR vs import * as ... in target):

🟢 Decreased ➖ Unchanged 🔴 Increased ❔ Unknown
0 325 0 0

No notable changes.

If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Minor suggestions only — the reskin looks consistent; one dark-mode note inline.

Reviewed changes — single commit restyling the prng-cpu-gpu example table to match the reskinned examples page.

  • Table styling — the table drops the rigid table-layout: fixed / 40rem / 10rem sizing for table-layout: auto; width: 100%, adds a #faf9f6/#000 background-plus-text pair and a 0.8em font, and inserts a <br /> into the "Arbitrary sample (max abs diff)" header to match the two-line header in the adjacent column.

The <br /> addition and the auto-layout switch are consistent with the other column and with the injected-HTML sizing model. No tests exercise this table (there is no per-example Playwright test for prng-cpu-gpu), so no test impact.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Comment thread apps/typegpu-docs/src/examples/tests/prng-cpu-gpu/index.html

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — the scroll-container rework checks out; one note on the border model inline.

Reviewed changes — since the prior review at 242d1edc, two commits landed: e9f8078 normalized the table font to rem units (matching sibling examples), and 5734b70 reworked the table into its own scroll container.

  • Scrollable tabledisplay: block; max-width/max-height: 100%; overflow: auto replaces the plain width: 100%, so a table taller than the aspect-square overflow-hidden preview box now scrolls internally instead of overflowing/clipping. Verified in headless Chromium: under a bounded container the table caps at 100% and scrolls; unconstrained it renders at natural height.
  • Typography + alignment — font dropped from 0.8rem to 0.7rem (on par with matrix-next), and th/td text is now centered.

Pullfrog  | Fix it ➔View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

@pullfrog

pullfrog Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Following up on the review above — the inline note referenced there couldn't be anchored to the diff in the review itself, so here's the content:

border-collapse: collapse is now inert. With the table switched to display: block (commit 5734b70), the collapsed border model no longer applies — it only affects table-level elements. Each cell now draws its own 1px #888 border, so internal gridlines render ~2px at the seams. Since the commit's purpose was the scroll container, the chunky borders are presumably accidental. An easy fix: use single-edge cell borders (e.g. border-bottom/border-right only) and drop the dead border-collapse — the grid stays crisp and the table keeps scrolling.

Pullfrog  | View workflow run | via Pullfrog | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Base automatically changed from impr/no-padding-around-example-view to release September 9, 2026 07:58
@cieplypolar
cieplypolar force-pushed the impr/cpugpu-example-new-layout branch from 5734b70 to 2daee5d Compare September 9, 2026 07:58
…mansion/TypeGPU into impr/cpugpu-example-new-layout
@cieplypolar
cieplypolar removed this pull request from stack #3005 September 9, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant