Skip to content

fix(@typegpu/gl): Pin an exact patch version of typegpu - #3016

Open
iwoplaza wants to merge 1 commit into
mainfrom
fix/pin-typegpu-in-gl
Open

iwoplaza wants to merge 1 commit into
mainfrom
fix/pin-typegpu-in-gl

Conversation

@iwoplaza

@iwoplaza iwoplaza commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Right now, pretty much every typegpu update changes the internals, in particular, WgslGenerator, causing @typegpu/gl to go out of sync. This change pins an exact typegpu patch version as a peer dependency.

@iwoplaza
iwoplaza marked this pull request as ready for review September 14, 2026 12:36
Copilot AI lite review requested due to automatic review settings September 14, 2026 12:36
@github-actions

Copy link
Copy Markdown

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@4dcb81b52d40a118964d59a6cad3db98bbe5e0b2
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/cli@4dcb81b52d40a118964d59a6cad3db98bbe5e0b2
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/gl@4dcb81b52d40a118964d59a6cad3db98bbe5e0b2

benchmark
view benchmark

commit
view commit

@github-actions

Copy link
Copy Markdown

Bundle size comparison (import * as ... in PR vs import * as ... in target):

🟢 Decreased ➖ Unchanged 🔴 Increased ❔ Unknown
0 325 0 0

No notable changes.

If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.

@github-actions

Copy link
Copy Markdown

Resolution Time Benchmark

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.85, 1.74, 4.00, 6.53, 6.97, 12.04, 23.43, 23.66]
  line [0.93, 1.86, 4.26, 6.08, 6.89, 10.84, 22.72, 25.13]
  line [0.93, 1.88, 3.94, 6.32, 7.12, 12.41, 23.21, 22.60]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.33, 0.58, 0.72, 0.87, 1.17, 1.22, 1.37, 1.44]
  line [0.32, 0.55, 0.69, 0.86, 1.12, 1.15, 1.37, 1.51]
  line [0.33, 0.52, 0.66, 0.79, 1.09, 1.15, 1.38, 1.49]
Loading
---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.74, 2.15, 4.06, 7.03, 11.70, 24.81, 54.33, 108.58]
  line [0.72, 2.11, 3.66, 7.20, 11.69, 24.68, 54.96, 110.25]
  line [0.80, 2.10, 3.15, 6.64, 11.56, 25.05, 55.34, 108.59]
Loading

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency update is focused and has no unresolved review issues.

Pull request overview

Pins typegpu to an exact workspace version for @typegpu/gl.

Changes:

  • Replaces the caret workspace range with an exact workspace reference.
File summaries
File Description
packages/typegpu-gl/package.json Pins the typegpu peer dependency to the exact workspace version.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • @typegpu/gl peer dependency pinned to an exact version: peerDependencies.typegpu in packages/typegpu-gl/package.json changed from workspace:^ to bare workspace:.

pnpm resolves a bare workspace: to the exact workspace version when packing (identical to workspace:*), so the published manifest will carry the exact typegpu version instead of a caret range. Verified on the repo-pinned pnpm 11.1.2. Note this intentionally differs from the eight sibling packages that keep workspace:^; the consumer-visible effect only lands after @typegpu/gl is version-bumped and released.

Pullfrog  | View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants