Conversation
WPT non-regression comparisonPASS — no regressions · 0 improved section(s) · overall 2717 → 2717 (0) Unchanged sections (28)
Baseline: Workflow run · this comment is updated on every push. |
mdydek
added
the
refactor
maciejmakowski2003
requested changes
Sep 16, 2026
maciejmakowski2003
left a comment
maciejmakowski2003
left a comment
Collaborator
There was a problem hiding this comment.
verify comments
Collaborator
There was a problem hiding this comment.
verify comments
|
|
||
| BoundedPriorityQueue<DeferredEvent, MAX_PENDING_EVENTS, ByDueTime> pending_; | ||
| std::shared_ptr<IAudioEventHandlerRegistry> registry_; | ||
| std::shared_ptr<AudioEventProducer> audioEventProducer_; |
Collaborator
There was a problem hiding this comment.
does it really has to hold audioEventProducer_?
Member
Author
There was a problem hiding this comment.
why not, if this queue is designed to always call events from audio thread, why it cannot capture it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist