Skip to content

feat: better workarts in notifications - #1291

Open
mdydek wants to merge 1 commit into
mainfrom
feat/workart-improvements
Open

mdydek wants to merge 1 commit into
mainfrom
feat/workart-improvements

Conversation

@mdydek

@mdydek mdydek commented Sep 17, 2026

Copy link
Copy Markdown
Member

Closes #1264, #1280

⚠️ Breaking changes ⚠️

Introduced changes

  • comparison on 4000 x 4000 artwork using argent:
    • android: 128 MB on main vs 3.1 MB on this branch (caching also included)
    • ios 32.5 MB on main vs 4.2 MB on this branch (caching also included)

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@mdydek mdydek changed the title feat: better workart feat: better workarts in notifications Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

WPT non-regression comparison

FAIL — 1 regressed section(s) · 0 improved section(s) · overall 2717 → 2716 (-1)

Spec section Base pass Head pass Delta
AudioBufferSourceNode 218 217 -1
Unchanged sections (27)
Spec section Base pass Head pass Delta
Processing model 0 0 0
Other 52 52 0
AnalyserNode 138 138 0
AudioBuffer 140 140 0
AudioContext 58 58 0
AudioNode 261 261 0
AudioParam 629 629 0
BiquadFilterNode 275 275 0
ChannelMergerNode 30 30 0
ChannelSplitterNode 7 7 0
ConstantSourceNode 64 64 0
ConvolverNode 203 203 0
DelayNode 104 104 0
DestinationNode 0 0 0
DynamicsCompressorNode 4 4 0
GainNode 15 15 0
IIRFilterNode 87 87 0
MediaElementAudioSourceNode 0 0 0
MediaStreamAudioDestinationNode 1 1 0
MediaStreamAudioSourceNode 0 0 0
OfflineAudioContext 35 35 0
OscillatorNode 104 104 0
PannerNode 75 75 0
PeriodicWave 33 33 0
ScriptProcessorNode 0 0 0
StereoPannerNode 102 102 0
WaveShaperNode 82 82 0

Baseline: 1966b4ac91efb990f1bc626fdb8899b034b770f4 · Candidate: 80f1402f5cf2677a0969588e2130ccc7210cf3f1

Workflow run · this comment is updated on every push.

@mdydek mdydek added the feature New user-facing features or major capabilities label Sep 17, 2026
@mdydek
mdydek force-pushed the feat/workart-improvements branch from 9d6f1b7 to 80f1402 Compare September 18, 2026 10:40
@mdydek
mdydek marked this pull request as ready for review September 18, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New user-facing features or major capabilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] PlaybackNotification.loadArtwork decodes artwork at full resolution — unbounded memory, no cache, no timeouts

1 participant