Convert clients/js and clients/js-legacy to oxlint and oxfmt - #775
Merged
joncinque merged 1 commit intoAug 28, 2026
Merged
Conversation
Replaces ESLint + Prettier with oxlint and oxfmt for both the clients/js and clients/js-legacy packages. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Audit failure was fixed with #776, landing on red |
joncinque
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces ESLint + Prettier with oxlint and oxfmt for both JS client packages (
clients/jsandclients/js-legacy), mirroring solana-program/token-group#115 and the follow-ups in token-metadata, libraries, memo, and record.Changes (applied identically to
clients/jsandclients/js-legacy)package.json: droppedeslint,prettier,@typescript-eslint/eslint-plugin,eslint-config-prettier,eslint-plugin-prettier, and@solana/prettier-config-solana; addedoxlintandoxfmt. Scripts now run the Oxc tools:lint→oxlint --max-warnings 0lint:fix→oxlint --fixformat→oxfmt --check .format:fix→oxfmt --write ..oxlintrc.json(new) mirrors the old.eslintrc.cjs(@typescript-eslint/recommended):correctnesscategory as errors, withban-ts-comment/no-explicit-any/explicit-function-return-type/explicit-module-boundary-typesdisabled to match the previous rules..oxfmtrc.json(new) migrated from.prettierrc.cjsviaoxfmt --migrate=prettier(single quotes,trailingComma: all, printWidth 100,endOfLine: lf, semicolons)..eslintrc.cjs,.eslintignore, and.prettierrc.cjs.pnpm-lock.yaml.Notes
pnpm lint/pnpm formatper package through the repoMakefile, so no workflow files needed changing.oxfmt-clean andoxlint-clean — no source reformatting in this PR.Verification
For both packages:
pnpm install,pnpm lint,pnpm format, andpnpm buildall succeed;clients/jspnpm test(tsc) passes. A rootpnpm install --frozen-lockfilesucceeds against the updated lockfile. (Theclients/js-legacyava/litesvmsuite needs the on-chain program.sobuilt viacargo build-sbf— not run in this environment; it is unaffected by the tooling change.)🤖 Generated with Claude Code