Skip to content

fix: wrong data attribute, default quality, img loading - #2

Open
lxsmnsyc wants to merge 3 commits into
mainfrom
expansion
Open

fix: wrong data attribute, default quality, img loading#2
lxsmnsyc wants to merge 3 commits into
mainfrom
expansion

Conversation

@lxsmnsyc

@lxsmnsyc lxsmnsyc commented Sep 9, 2026

Copy link
Copy Markdown
Member

This fixes 3 issues:

  • data attribute used still uses "start" instead of "solid" (mismatched with the css file too)
  • DEFAULT_QUALITY was set to 0.8 instead of 80
  • The client <img> gets src={props.src.source}, and the bogus <source src> fallback is gone. The server <img> renders the blank SVG placeholder of the same size, so no fetch happens before intersection.

also sets up playwright for more tests, and expanded the README

@socket-security

socket-security Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​vitest/​browser@​4.1.10991007999100
Addedplaywright@​1.63.01001001009980
Added@​vitest/​browser-playwright@​4.1.101001008598100

View full report

@pkg-pr-new

pkg-pr-new Bot commented Sep 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/image@2

commit: 0105842

@lxsmnsyc
lxsmnsyc added this pull request to stack #4 September 9, 2026 16:37
Cut words that added no information and turned trailing prose into lists.
Dropped the duplicate install blocks for pnpm and yarn.
Trimmed the usage example to the parts a reader needs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant