fix: emitFile, eager/priority modes, noscript, srcset - #5
Open
lxsmnsyc wants to merge 1 commit into
Open
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops the browser from ever downloading the untouched original, sends processed
files through the bundler, and adds an
eagerprop for the image above thefold. Readers with no JavaScript now get the image.
Changes
imgcarries asrcsetbuilt from the last output format. A browser thatsupports none of the
sourcetypes now picks a sized variant instead of thefull size original.
outputoption now matters. The last format is the fallback,so it should be the most widely supported one.
original file is no longer imported, so it never reaches the bundle.
emitFile, sobase,assetsDirand the build manifest apply to them. The dev server still writesthem to the public directory.
SolidImagetakes aneagerprop. The image loads without waiting for theobserver, and the server renders it in full so the browser finds it while it
parses the page.
noscriptcopy of the image. Browsers never load thecontent of a
noscriptelement, so it costs nothing for everyone else.sourceelementsand the
img.