Version Packages (next) - #602
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.
nextis currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, runchangeset pre exitonnext.Releases
@solidjs/router@2.0.0-next.24
Patch Changes
65f41f3: Navigations are declared to Solid's observe tier. Every client location write —
navigate(), a redirect chased while the previous target is still pending, the browser's own back/forward — now runs insideOBSERVE.attribution.withOriginwith the parametrized route pattern, params, and origin location, so the attribution engine names holds and re-runs after the route (navigation to /users/:id (/users/42)), times the navigation from the user event to settle, folds redirect hops onto the navigation they belong to (redirected from /files), and reports routes infeedback().navigations. The route name and params are read late — at settle — so a lazy route subtree that loaded during the hold is named by the exact route it resolved to, not its placeholder. The router's location signal and itsmatches,routingPending, and lazy-subtree memos carry names so they read as themselves in diagnostics rather than assignal/computed.Nothing changes in production builds:
OBSERVEis undefined there and the declaration folds out. Requiressolid-js2.0.0-rc.8 (OBSERVE.attribution.withOrigin).