[Bug] 'Check for updates on startup' is no longer working?

[goran-w]

I've noticed that the "Check for updates on startup" Preferences option appears to be broken. (I'm aware that it only checks at most once per day.)

The (non-manually) else if-block in Check4Update() seems to lack a call to ShowSelfUpdateResult(), here added by me to illustrate where it's missing and to test this fix (which seems to be working) :

I could submit a PR, but would like to check whether this is the "correct" fix...

---

On a side note, the implicit (hidden) feature of "only check for updates once on the same day" somewhat contradicts the phrasing of the option "Check for updates on startup" which really sounds like it would check on EACH startup. This makes it easy to think that auto-check is broken, even when it's not... I'd suggest to remove this ambiguity by any of these 3 solutions:

• Leave the current implementation as-is, but clarify its behavior by renaming the option to "Check for updates on startup (once per day)".
• Add a 2nd checkbox option "Only check once per day" next to "Check for updates on startup".
• Make auto-check more straight-forward by actually checking on every startup (after all, there's already a "Skip This Version" feature).

Personally, I'd vote for the last solution, for the following reasons:

• Checking on EACH startup would not postpone notification of a new version until tomorrow, if SourceGit was already launched earlier today (before the new version was published) and then again after the release.
• I may not be ready to update when the notification pops up the first time, but I would still expect to be reminded on the next startup as well. (I don't find it very annoying to be reminded on each start.) But if I make a lot of restarts and DO start to get annoyed, I can always press the "Skip This Version" button. (At that stage, I would probably be getting annoyed the next day too, so this option is a sufficient one and a better fit anyway.)

[love-linger]

When automatically detecting updates, when a new version is found, SourceGit will not directly prompt users, but a highlighted button will appear in the title bar. Reduce the interference to users. It runs once time per day because the version file is stored in GitHub, and it has a limit on the frequency and daily number of accesses. Considering that users can detect it manually, and it is not a problem to detect the new version even if it is delayed by one day, it is designed in this way.

[goran-w]

When automatically detecting updates, when a new version is found, SourceGit will not directly prompt users, but a highlighted button will appear in the title bar. Reduce the interference to users.

👀 Oh, I see it now. 🤦‍♂️😅 Very unintrusive! 😂 (Screenshot below shows its tooltip as well...)

---

It runs once time per day because the version file is stored in GitHub, and it has a limit on the frequency and daily number of accesses.

Ah, makes sense!

Considering that users can detect it manually, and it is not a problem to detect the new version even if it is delayed by one day, it is designed in this way.

OK - I'm fine with that, since I now know the reasoning behind it.

My only remaining "wish" then is to clarify its behavior, by simply renaming the Preferences option to "Check for updates on startup (once per day)" or similar! 😉