Conversation
eseliger
marked this pull request as ready for review
August 22, 2026 23:32
christoph-sg
force-pushed
the
prototype-members
branch
from
September 10, 2026 13:33
ae8b70f to
f7045c6
Compare
christoph-sg
force-pushed
the
prototype-members
branch
from
September 11, 2026 08:58
f7045c6 to
c4b6813
Compare
christoph-sg
force-pushed
the
prototype-members
branch
2 times, most recently
from
September 11, 2026 09:16
c2f4bea to
cc77479
Compare
christoph-sg
force-pushed
the
prototype-members
branch
from
September 11, 2026 09:27
cc77479 to
9880029
Compare
christoph-sg
force-pushed
the
prototype-members
branch
from
September 11, 2026 09:44
9880029 to
73738a5
Compare
Contributor
|
This appears to cover only whole-object replacement ( I think if we're doing this, we should also cover those common variants to avoid surprises (the first 5 in this table)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat object literals assigned to
Constructor.prototypeas members of the constructor when generating SCIP symbols. This gives the prototype object, method declarations, function-valued properties, and data properties stable constructor-owned symbols that connect to references in other files without dangling intermediate locals.Fixes #409.