Skip to content

Derive the ISO 639 sets from the registration authority data - #106

Merged
jviotti merged 2 commits into
mainfrom
iso639-5-fix
Jul 27, 2026
Merged

Derive the ISO 639 sets from the registration authority data#106
jviotti merged 2 commits into
mainfrom
iso639-5-fix

Conversation

@jviotti

@jviotti jviotti commented Jul 27, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Jul 27, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates the ISO 639 language datasets so the published “sets” are derived directly from the official registration authority sources.

Changes:

  • Adds ISO 639-5 TSV (LOC) as a new vendored data source
  • Extends the build pipeline to convert ISO 639-5 TSV to JSON and pass it into language set generation
  • Reworks templates/build/iso/language/enriched.jq so Set 5 comes from ISO 639-5 data (instead of heuristics on ISO 639-2 names)
  • Expands Set 2 (bibliographic + terminologic) to include all registered ISO 639-2 code elements (individual, collective, special)
  • Models the reserved local-use range (qaaqtz) as a regex branch and excludes the qaa-qtz range marker row
  • Updates schema templates accordingly (per-code x-jsonld-self and new “Reserved for local use” branch)
  • Updates tests to cover special/collective codes and the reserved local-use range

Technical Notes: Set 2 terminologic is generated as “bibliographic except for the ~20 divergent pairs”, and Set 5 now tracks the LOC ISO 639-5 vocabulary directly.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread DATA
vendor/data/xbrl/utr/utr.xml https://www.xbrl.org/utr/utr.xml
vendor/data/iso/language/ISO-639-2_utf-8.txt https://www.loc.gov/standards/iso639-2/ISO-639-2_utf-8
vendor/data/iso/language/iso-639-3_Code_Tables https://iso639-3.sil.org/sites/iso639-3/files/downloads/iso-639-3_Code_Tables_20251015.zip
vendor/data/iso/language/iso639-5.tsv http://id.loc.gov/vocabulary/iso639-5.tsv

@augmentcode augmentcode Bot Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new ISO 639-5 source URL is plain http://; since https://id.loc.gov/vocabulary/iso639-5.tsv is available, sticking to HTTPS would avoid environments that block HTTP and provides transport integrity for vendored data downloads.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Not reviewed (too large): schemas/2020-12/iso/language/2023/set-2-terminologic.json (~3,939 lines), schemas/2020-12/iso/language/2023/set-2-bibliographic.json (~823 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.

Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic

Comment thread templates/schemas/2020-12/iso/language/2023/set-5.jq
Comment thread DATA
@jviotti
jviotti merged commit 572319c into main Jul 27, 2026
3 checks passed
@jviotti
jviotti deleted the iso639-5-fix branch July 27, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant