fix(acp): launch built-in subagents with protocol v2 - #214
Merged
Merged
Conversation
danielkov
enabled auto-merge (squash)
September 13, 2026 20:49
![kit-code-agent[bot]](https://avatars.githubusercontent.com/in/4797102?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launch default built-in Kit subagents with
acp --protocol-version 2, matching the parent's v2 initialization request. Apply the same default to new and resumed children while preserving configured harness arguments.Motivation
The default
kit acpendpoint serves v1 and rejects the parent's v2 offer before Kit's initialization handler can negotiate a response, preventing built-in subagents from starting.Impact
This fixes the built-in launch mismatch without changing the standalone ACP command's default or custom harness profiles. Generic v2-to-v1 fallback is tracked separately in #213.