Skip to content

feat(tui): group nested ACP calls beneath compose - #215

Merged
danielkov merged 2 commits into
mainfrom
assess/acp-runlet-sidechannel
Sep 14, 2026
Merged

feat(tui): group nested ACP calls beneath compose#215
danielkov merged 2 commits into
mainfrom
assess/acp-runlet-sidechannel

Conversation

@danielkov

@danielkov danielkov commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Display nested ACP tool calls beneath their owning compose call using explicit parent identities. Each child retains its own status, output, images, and expansion state instead of matching execution to Runlet source nodes.

Motivation

Nested tool activity already arrives over ACP independently of stderr. Use that authoritative lifecycle to keep the transcript useful when source-level progress is unavailable.

Impact

Compose groups show up to 32 child cards per page, with Alt+PageUp/PageDown navigation. Orphans remain visible, late attachment preserves selection, and background descendants continue updating after their parent completes. Duplicate stderr-derived tool presentation is disabled while diagnostic heartbeats remain active.

Technical details

Canonical call records remain independent; indexed parent relationships determine presentation ownership and invalidate the owning transcript cache. Explicit collapse is preserved, and copying grouped output retains each child's logical line identity. Terminal-only content can use parallel raw output when available; terminal stream replay is not added.

Legacy Runlet observation and stderr reducers remain for removal in the follow-up stacked PR.

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two regressions need attention: filtering transport heartbeats permanently disables retained runtime-status updates after lease expiry, and grouped-call paging consumes the prompt editor's word-navigation shortcuts.

Comment thread src/tui/mod.rs Outdated
Comment thread src/tui/app.rs

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

@danielkov
danielkov added this pull request to stack #217 September 14, 2026 08:53
@danielkov
danielkov merged commit 9270b60 into main Sep 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant