fix(config): rename on-disk config file to splunk-ao-config.json (HYBIM-918) - #190
fix(config): rename on-disk config file to splunk-ao-config.json (HYBIM-918)#190etserend wants to merge 3 commits into
Conversation
204b656 to
2c0b6ca
Compare
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: approve — Correct, well-scoped rename matching the ticket; docs, changelog, and a regression test are all consistent with no stale references.
Follow-ups
Suggested follow-up work that could be tracked as Jira tickets:
src/splunk_ao/config.py:74-74: The config directory remains~/.galileo/(still using the old brand name) while only the filename is rebranded tosplunk-ao-config.json. Consider a separate ticket to evaluate renaming the directory for brand consistency, if desired.
|
Follow-up ticket created: https://splunk.atlassian.net/browse/HYBIM-952 |
…o-config.json (HYBIM-918) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…k-ao-config.json (HYBIM-918) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2c0b6ca to
e59ad46
Compare
|
CHANGELOG.md contains a change unrelated to this PR. After the rebase onto current `main`, the `CHANGELOG.md` hunk re-adds the entire `### Breaking Changes` section — which includes a second bullet that is out of scope for HYBIM-918: ```
That `flush()`/`async_flush()` entry was deliberately removed from `main` in the release-refresh commit (`acc2d24`) — it no longer exists anywhere in `main`'s CHANGELOG. Re-introducing it here would silently revert that intentional edit. This PR's CHANGELOG change should contain only the config-file rename entry: ``` Breaking Changes
Could you drop the `flush()` bullet from the CHANGELOG hunk? The other three files (`config.py`, `test_config.py`, migration-tool `README.md`) look clean. |
…GELOG hunk Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Summary
SplunkAOConfig.config_filenamefromgalileo-python-config.json→splunk-ao-config.json(src/splunk_ao/config.py:74)CHANGELOG.mdBreaking Change
Users with saved credentials at
~/.galileo/galileo-python-config.jsonmust either rename the file to~/.galileo/splunk-ao-config.jsonor delete it and re-authenticate.Test plan
grepconfirms no tests reference the old filename — no test changes neededpoetry run pytest); skipped tests are pre-existing optional-dep issues unrelated to this changeJira: HYBIM-918
🤖 Generated with Claude Code