Compare config tree values by content on refresh - #1741
Open
arimu1 wants to merge 1 commit into
Open
Conversation
ContextRefresher used reference equality for property changes, so ConfigTreePropertySource values were always reported as changed. Fixes spring-cloudgh-1687 Signed-off-by: arimu1 <19286898+arimu1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContextRefresherwhen the environment uses Spring BootConfigTreePropertySource.ConfigTreePropertySource.Value(includingPropertyFileContent) does not implementequals/hashCode, so every refresh incorrectly reported all config tree keys as changed.CharSequence/toString()instead of reference equality.Fixes gh-1687
Test plan
./mvnw -pl spring-cloud-context -am testContextRefresherConfigTreeTestscovering unchanged config tree refresh (no spurious keys) and changed content (key reported).