Escape constant names in queries#4525
Open
snprajwal wants to merge 1 commit into
Open
Conversation
The `any` keyword was introduced in Go 1.18, and can be used in place
of `interface{}`. This was not in the list of reserved keywords, leading
to identifiers using this term in generated code.
Update the logic to escape constant names, and also add `any` to the
list of reserved keywords.
Signed-off-by: Prajwal Nadig <prajwalnadig21@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
anykeyword was introduced in Go 1.18, and can be used in place ofinterface{}. This was not in the list of reserved keywords, leading to identifiers using this term in generated code.Update the logic to escape constant names, and also add
anyto the list of reserved keywords.This is a minimal rebased version of #3961, which I'm unable to reopen. It only contains the changes that fix invalid code generation.