Update plugin org.jetbrains.kotlin.jvm to v2.4.10 - #3681
Conversation
Task List Completed has been disabled for this PR, either by the disabled label or repo topicRemaining tasksWhy am I seeing this comment?This comment is a summary of the pending tasks on this PR. It is intended to make it easier to find pending tasks so you can ship your PR faster. Got feedback? Let us know in #dx-help!
Want to disable me? Add |
63704f6 to
ca37f67
Compare
Kotlin 2.4.10 raises two blockers. KotlinJsProjectExtension is now deprecated with level ERROR. Applying the org.jetbrains.kotlin.js plugin now fails hard. Suppress the deprecation in WireBuildPlugin and WirePlugin. The Wire plugin keeps support for js-only consumers. Migrate samples/js to the multiplatform plugin with a js target and move its sources to the KMP layout. Regenerate kotlin-js-store/yarn.lock with kotlinUpgradeYarnLock. Co-authored-by: Benoît Quenaudon <benoit@quenaudon.com> Signed-off-by: Benoît Quenaudon <benoit@quenaudon.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
The Kotlin 2.4 compiler mangles internal members with the full module name. The suffix moves from wire_schema to com_squareup_wire_wire_schema for two internal functions. Internal members are not part of the public contract, so the dump update is safe. Co-authored-by: Benoît Quenaudon <benoit@quenaudon.com> Signed-off-by: Benoît Quenaudon <benoit@quenaudon.com>
samples/multi-target already builds Wire on a Kotlin/JS target, so the js sample was redundant. The js sample was also the only browser-target consumer, so the shared yarn.lock drops the webpack and css tooling. Co-authored-by: Benoît Quenaudon <benoit@quenaudon.com> Signed-off-by: Benoît Quenaudon <benoit@quenaudon.com>
Kotlin 2.4 turns applying org.jetbrains.kotlin.js into an error. The Wire Gradle plugin no longer reacts to the org.jetbrains.kotlin.js and kotlin2js plugin ids, and no longer adds the wire-runtime dependency for js-only projects. This is a behavior change for consumers on older Kotlin versions that still apply the Kotlin/JS plugin: they must use the Kotlin multiplatform plugin with a js target instead. This also removes the DEPRECATION_ERROR suppressions in wire-gradle-plugin and build-support, which existed only for that plugin. Co-authored-by: Benoît Quenaudon <benoit@quenaudon.com> Signed-off-by: Benoît Quenaudon <benoit@quenaudon.com>
|
This PR now also drops support for the deprecated Kotlin/JS plugin. The Wire Gradle plugin no longer reacts to the org.jetbrains.kotlin.js and kotlin2js plugin ids, and no longer adds the wire-runtime dependency for js-only projects. This is a behavior change for consumers on older Kotlin versions that still apply the Kotlin/JS plugin: they must use the Kotlin multiplatform plugin with a js target instead. The js sample is also removed; samples/multi-target still covers Wire on a Kotlin/JS target. |
1 participant
This PR contains the following updates:
2.3.21→2.4.10Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.