Document the current theme packages and Rust usage - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The README used future-tense ownership, did not show how to consume the Rust catalog, and left generated package READMEs on older catalog versions. It also did not distinguish the published Cargo crate from the repository-only JavaScript package tree.
Implementation Approach
stack-themecatalog example and docs.rs link.Testing Approach
npm run validatenpm run generate:checknpm testnpm run typecheckcargo test --workspace --lockedcargo doc --workspace --no-deps --lockedReview Perspectives / Points of Concern
Please verify that the distribution section clearly distinguishes generated package parity from a standalone public npm release.