Add configured theme palette overrides - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Users need palette-only custom themes that can use any valid theme identifier, including intentional overrides of the built-in
default,light, anddarknames. Resolution must remain deterministic and must not turndefault extends defaultinto a cycle. This follows the language and host-resolution contract proposed in stack-sh/specification#12.Implementation Approach
extendsvalue from the immutable built-in catalog, replace built-in names in place, and append new names in identifier order.Testing Approach
extends, invalid identifiers, invalid colors, empty palettes, definition limits, normalized revisions, and warnings.Review Perspectives / Points of Concern
extendsalways reads the pre-overlay built-in catalog.default,light, ordarkcolor choices.