-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add/Edit Bookmark Dialog #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
F3l1x1vo
wants to merge
19
commits into
main
Choose a base branch
from
feat/app-bookmark-dialog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e0fe691
#270 add bookmark dialog
F3l1x1vo 80b1716
add edit bookmarks dialog
F3l1x1vo b866c48
fix cancel editing bookmark
F3l1x1vo a663c17
fix darkmode for icons, cursor pointer over boxes
F3l1x1vo 52340e1
update product icons to use colored versions where possible
F3l1x1vo 1f9f85e
scaled icons down to 64x64
F3l1x1vo d93d2fe
Revert "scaled icons down to 64x64"
F3l1x1vo 3684df3
revert image downscale, use svelte enhanced image component to downsc…
F3l1x1vo 72426d6
fix unit test
F3l1x1vo 53dd975
Add OPA client for admin rights checking (#276)
dklOrdix 1ccbb04
#270 add admin check to pinning, add OPA tests
F3l1x1vo a0e5f1c
fix unit test
F3l1x1vo 33bc633
#270 show pin for all only to admins
F3l1x1vo 7a7d76c
fix unit test
F3l1x1vo edd5d5f
#271 overhaul dashboard layout design (#281)
F3l1x1vo fc1c717
Add bookmarks to sidebar, add pinning of bookmarks, display bookmarks…
F3l1x1vo dd9a256
fix styling
F3l1x1vo a008a2b
Merge remote-tracking branch 'origin/main' into feat/app-bookmark-dialog
F3l1x1vo d022e4d
#293 remove support for embedded external services
F3l1x1vo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| # A long random secret used to sign sessions and tokens (min 32 characters) | ||
| STACKABLE_COCKPIT_SESSION_SECRET=change-me-to-a-long-random-secret-min-32-chars | ||
|
|
||
| # The publicly accessible base URL of this application | ||
| # The publicly accessible base URL of this application. | ||
| # In development this is derived from the request host (so any free port works, | ||
| # e.g. when 5173 is already taken). In production builds this value is used | ||
| # directly for the OIDC redirect URI and must match the public origin. | ||
| STACKABLE_COCKPIT_BASE_URL=http://localhost:5173 | ||
|
|
||
| # OIDC discovery URL (Keycloak, Entra ID, or any compliant OIDC provider) | ||
|
|
@@ -40,4 +43,8 @@ STACKABLE_COCKPIT_OIDC_CLIENT_SECRET=your-client-secret | |
| # Feature flags | ||
| # STACKABLE_COCKPIT_COMPLETION_ENABLED=false # Disable SQL editor code completion (default: true) | ||
| # STACKABLE_COCKPIT_STORAGE_BROWSER_ENABLED=true # Enable S3/HDFS file browser (default: false) | ||
| # PUBLIC_STACKABLE_COCKPIT_UPLOAD_CONCURRENCY=3 # Maximum number of concurrent file uploads (default: 3) | ||
|
|
||
| # OPA (Open Policy Agent) — admin rights checking | ||
| # STACKABLE_COCKPIT_OPA_ENABLED=true # Enable OPA admin checks (default: false) | ||
|
Comment on lines
+47
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Small contradiciton here. i guess most users would copy the .env.example to craft there own. If they do, the default is true while comment says false |
||
| # STACKABLE_COCKPIT_OPA_URL=http://localhost:8181 # OPA server base URL (required when enabled) | ||
| # STACKABLE_COCKPIT_OPA_TIMEOUT=5000 # OPA request timeout in milliseconds (default: 5000) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,3 +33,4 @@ coverage/ | |
| # Helm templates | ||
| deploy/helm/ | ||
| dev/garage/ | ||
| dev/opa/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| apiVersion: v2 | ||
| name: opa | ||
| description: Open Policy Agent for local dev and E2E testing | ||
| type: application | ||
| version: 0.1.0 | ||
| appVersion: '1.16.2' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package stackable | ||
|
|
||
| default admin = false | ||
|
|
||
| # Admin if user ID is in the hardcoded admin list | ||
| admin if { | ||
| admin_users[input.user.id] | ||
| } | ||
|
|
||
| # Admin if user email ends with the admin domain | ||
| admin if { | ||
| endswith(input.user.email, "@admin.example.com") | ||
| } | ||
|
|
||
| admin_users := { | ||
| "admin-user-id-1": true, | ||
| "admin-user-id-2": true, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: opa-policies | ||
| namespace: default | ||
| data: | ||
| admin.rego: |- | ||
| {{- .Files.Get "policies/admin.rego" | nindent 4 }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| --- | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: opa | ||
| namespace: default | ||
| labels: | ||
| app: opa | ||
| spec: | ||
| replicas: 1 | ||
| selector: | ||
| matchLabels: | ||
| app: opa | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: opa | ||
| spec: | ||
| containers: | ||
| - name: opa | ||
| image: '{{ .Values.image.repository }}:{{ .Values.image.tag }}' | ||
| imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
| args: | ||
| - run | ||
| - --server | ||
| - --addr | ||
| - 0.0.0.0:8181 | ||
| - '{{ .Values.policyMountPath }}/admin.rego' | ||
| ports: | ||
| - name: http | ||
| containerPort: 8181 | ||
| protocol: TCP | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /health | ||
| port: 8181 | ||
| initialDelaySeconds: 2 | ||
| periodSeconds: 3 | ||
| failureThreshold: 10 | ||
| livenessProbe: | ||
| httpGet: | ||
| path: /health | ||
| port: 8181 | ||
| initialDelaySeconds: 5 | ||
| periodSeconds: 10 | ||
| volumeMounts: | ||
| - name: policies | ||
| mountPath: '{{ .Values.policyMountPath }}' | ||
| readOnly: true | ||
| resources: | ||
| requests: | ||
| cpu: {{ .Values.resources.requests.cpu }} | ||
| memory: {{ .Values.resources.requests.memory }} | ||
| limits: | ||
| cpu: {{ .Values.resources.limits.cpu }} | ||
| memory: {{ .Values.resources.limits.memory }} | ||
| volumes: | ||
| - name: policies | ||
| configMap: | ||
| name: opa-policies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: opa | ||
| namespace: default | ||
| spec: | ||
| type: NodePort | ||
| selector: | ||
| app: opa | ||
| ports: | ||
| - name: http | ||
| port: 8181 | ||
| targetPort: 8181 | ||
| nodePort: {{ .Values.nodePort }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| image: | ||
| repository: openpolicyagent/opa | ||
| tag: 1.16.2 | ||
| pullPolicy: IfNotPresent | ||
|
|
||
| # NodePort for the OPA HTTP API. | ||
| nodePort: 30181 | ||
|
|
||
| # Path inside the container where policies are loaded from. | ||
| policyMountPath: /policies | ||
|
|
||
| resources: | ||
| requests: | ||
| cpu: 50m | ||
| memory: 64Mi | ||
| limits: | ||
| cpu: 200m | ||
| memory: 128Mi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to remove this?