docs: Add values.schema.json and document the used values - #756
Merged
Merged
Conversation
Follows hive-operator, but written for this chart: it is a CSI driver with a controller Deployment and a node driver DaemonSet, so the value surface is its own. Having a schema makes Helm validate values on install, upgrade, lint and template AND shows as a nice reference on ArtifactHub. One thing to note is that we include the "global" block even if it's not used by us. This is due to https://helm.sh/de/docs/chart_template_guide/subcharts_and_globals/ In short: When used as a subchart Helm injects a "global" into every subchart. If we don't declare it validation will fail when used as a subchart. kubernetesClusterDomain and the two priorityClassName keys are read by the templates but were missing from values.yaml, so they are documented there now. This also documents all used values in values.yaml itself. NOTES.txt is not part of this since operator-templating#646 generates it.
lfrancke
force-pushed
the
push-mtkoltlrkknv
branch
from
September 14, 2026 16:00
b4a0dae to
d172cbe
Compare
Techassi
approved these changes
Sep 15, 2026
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follows hive-operator roughly but it is the first operator (listener is the other) that is different so some strings are different. I checked all of them and it reads well enough. I'd say it can be waved through but feel free to read the schema!
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker