Skip to content

Rename legacy staged identifiers to the staging naming - #375

Open
aram356 wants to merge 1 commit into
mainfrom
rename-staged-to-staging
Open

Rename legacy staged identifiers to the staging naming#375
aram356 wants to merge 1 commit into
mainfrom
rename-staged-to-staging

Conversation

@aram356

@aram356 aram356 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pure rename, no behavior change: internal identifiers still using the older "staged" naming now match the user-facing deploy --staging terminology.
  • DeployStagedDeployStaging (both enums), deploy_stageddeploy_staging, split_staged_passthroughsplit_staging_passthrough, StagedPassthroughStagingPassthrough, plus the test helpers and test names built from them; doc-comment back-references updated.

Changes

Crate / File Change
crates/edgezero-adapter/src/registry.rs AdapterAction::DeployStagedDeployStaging
crates/edgezero-cli/src/adapter.rs Action::DeployStagedDeployStaging (Display string deploy --staging unchanged)
crates/edgezero-cli/src/lib.rs Updated Action::DeployStaging call sites
crates/edgezero-adapter-fastly/src/cli.rs deploy_stageddeploy_staging, split_staged_passthroughsplit_staging_passthrough, StagedPassthroughStagingPassthrough, test helpers and test names, doc back-references
crates/edgezero-adapter-{axum,cloudflare,spin}/src/cli.rs Renamed variant in unsupported-action match arms

Closes

Closes #374

Test plan

  • cargo test --workspace --all-targets (1421 passed, 0 failed)
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo fmt --all -- --check
  • cargo check --workspace --all-targets --features "fastly cloudflare spin"
  • WASM builds: wasm32-wasip2 (Spin) via cargo check -p edgezero-adapter-spin --target wasm32-wasip2 --features spin; Fastly/Cloudflare targets covered by the feature check above and CI
  • examples/app-demo workspace: cd examples/app-demo && cargo test --workspace --all-targets
  • Docs build: cd docs && npm run lint && npm run format && npm run build
  • Manual testing via edgezero serve --adapter axum
  • Other: repo-wide grep confirms zero remaining matches for the old identifiers

Checklist

  • Changes follow CLAUDE.md conventions
  • No Tokio deps added to core or adapter crates
  • Route params use {id} syntax (not :id)

Pure rename, no behavior change: DeployStaged -> DeployStaging,
deploy_staged -> deploy_staging, split_staged_passthrough ->
split_staging_passthrough, StagedPassthrough -> StagingPassthrough,
plus the test helpers and test names built from them. Doc-comment
back-references updated to match. The user-facing CLI surface
(deploy --staging) was already named staging and is unchanged.
@aram356 aram356 self-assigned this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename legacy staged identifiers to the staging naming

2 participants