Skip to content

fix(acs-ci): time-limit GCS preflight - #212

Merged
robbycochran merged 1 commit into
mainfrom
codex/acs-preflight-timeout
Sep 17, 2026
Merged

robbycochran merged 1 commit into
mainfrom
codex/acs-preflight-timeout

Conversation

@robbycochran

@robbycochran robbycochran commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Bound the sandbox GCS connectivity probe so a proxy or TLS failure produces an artifact promptly instead of hanging the preflight.

Summary by CodeRabbit

  • Bug Fixes
    • Added a 30-second timeout to the nightly preflight GCS bucket check to prevent it from hanging indefinitely.

@stackrox-openshell-workflow stackrox-openshell-workflow Bot added the stackrox-ai-review Opt in to StackRox AI review label Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fef63de7-728b-42f2-88e4-1b6b80ef7cb8

📥 Commits

Reviewing files that changed from the base of the PR and between 5efe5ca and afbea35.

📒 Files selected for processing (1)
  • tasks/acs-ci-nightly/workflow/preflight.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.


Walkthrough

The preflight workflow now limits the GCS bucket check to 30 seconds. Timeout failures use the existing nonzero-exit handling.

Changes

GCS bucket check

Layer / File(s) Summary
Add GCS bucket check timeout
tasks/acs-ci-nightly/workflow/preflight.yaml
The GCS bucket check now runs through timeout 30s. Existing exit-status logging and failure handling remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to afbea

The GCS preflight is bounded as intended, with timeout failures still reported through the existing failure path.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a time limit to the ACS CI GCS preflight check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@robbycochran
robbycochran merged commit 333da24 into main Sep 17, 2026
12 of 13 checks passed
@robbycochran
robbycochran deleted the codex/acs-preflight-timeout branch September 17, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stackrox-ai-review Opt in to StackRox AI review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant