fix(acs-ci): configure gsutil Boto CA bundle - #213
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review. WalkthroughThe nightly harness and preflight workflows configure Boto to use the OpenShell CA bundle. The preflight workflow now runs the Jira connectivity check before the GCS bucket check. ChangesBoto and preflight workflow updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The workflows use the documented OpenShell CA-bundle contract, and the preflight ordering and failure handling remain intact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| - content: | | ||
| [Boto] | ||
| ca_certificates_file = /etc/openshell-tls/ca-bundle.pem | ||
| destination: /tmp/openshell-boto.cfg |
There was a problem hiding this comment.
Using a predictable filename in /tmp can lead to a race condition. A malicious actor could create a symbolic link at this path to trick the application into overwriting an arbitrary file or using a malicious Boto configuration. It is safer to create this file in a more secure, less predictable location, for instance under the /sandbox directory.
| - content: | | ||
| [Boto] | ||
| ca_certificates_file = /etc/openshell-tls/ca-bundle.pem | ||
| destination: /tmp/openshell-boto.cfg |
There was a problem hiding this comment.
Using a predictable filename in /tmp can lead to a race condition. A malicious actor could create a symbolic link at this path to trick the application into overwriting an arbitrary file or using a malicious Boto configuration. It is safer to create this file in a more secure, less predictable location, for instance under the /sandbox directory.
Configure gsutil through BOTO_CONFIG with the OpenShell CA bundle. The Cloud SDK custom CA variable does not reach this standalone gsutil; put the setting in the Boto config used by both the preflight and main ACS task. Run the Jira probe first so the two checks report independently.
Summary by CodeRabbit