fix(acs-ci): enable gsutil metadata credentials - #214
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review. WalkthroughThe preflight and harness Boto configurations now select the ChangesBoto metadata credentials
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The workflows consistently configure metadata credential lookup for gsutil, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
cc04d66 to
550d146
Compare
| [GoogleCompute] | ||
| service_account = default | ||
| destination: /tmp/openshell-boto.cfg | ||
|
|
There was a problem hiding this comment.
Using a fixed path in /tmp can be risky if the runner environment ever shares /tmp between concurrent executions. Consider writing this configuration to a path inside the working directory (e.g., /sandbox/boto.cfg) to ensure isolation.
|
|
||
| [GoogleCompute] | ||
| service_account = default | ||
| destination: /tmp/openshell-boto.cfg |
There was a problem hiding this comment.
Using a fixed path in /tmp can be risky if the runner environment ever shares /tmp between concurrent executions. Consider writing this configuration to a path inside the working directory (e.g., /sandbox/boto.cfg) to ensure isolation.
The ACS CI nightly task configures the OpenShell google-cloud provider, which exposes the GCP service-account token through the GCE metadata path.
The Boto file previously configured only the OpenShell CA bundle, so standalone gsutil never enabled its metadata credential lookup and reported no configured credentials. Add [GoogleCompute] service_account=default to both the preflight and main workflows.
Validation:
Summary by CodeRabbit
New Features
Documentation