fix(acs-ci): pin legacy GCP metadata endpoints - #216
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review. WalkthroughThe change configures both legacy gsutil metadata variables for the OpenShell loopback emulator in the README and nightly workflow environments. The preflight GCS check uses the same endpoint without changing its timeout or error handling. ChangesMetadata endpoint configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The metadata configuration is consistent across the nightly workflow and local emulator, with no concrete merge-blocking risk established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
a304016 to
19e2ade
Compare
The Jira preflight now passes. Legacy gsutil still receives a metadata 403 because its apitools credential path uses GCE_METADATA_ROOT/GCE_METADATA_IP rather than the newer OpenShell provider variables.
Set both variables to OpenShell's loopback metadata emulator in both task workflows, and set them explicitly on the gsutil process in preflight.
Validation:
Summary by CodeRabbit