Skip to content

fix(acs-ci): use absolute gcloud path - #218

Merged
robbycochran merged 1 commit into
mainfrom
codex/acs-gcloud-absolute
Sep 17, 2026
Merged

robbycochran merged 1 commit into
mainfrom
codex/acs-gcloud-absolute

Conversation

@robbycochran

@robbycochran robbycochran commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

OpenShell replaces the sandbox PATH at runtime, so the first gcloud migration could not find the image-installed CLI even though the image contains it. Use the pinned absolute path in the trusted preflight command; it matches the task policy executable rule.

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability of the GCS preflight check by explicitly locating the Google Cloud CLI executable.
    • Existing timeout, bucket selection, output handling, and pass/fail behavior remain unchanged.

@stackrox-openshell-workflow stackrox-openshell-workflow Bot added the stackrox-ai-review Opt in to StackRox AI review label Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9850d036-214a-4596-9d12-dea9c91b44e5

📥 Commits

Reviewing files that changed from the base of the PR and between 7a91533 and f58a6e3.

📒 Files selected for processing (1)
  • tasks/acs-ci-nightly/workflow/preflight.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 6 remain after this review.


Walkthrough

The GCS preflight check now invokes gcloud through /opt/google-cloud-sdk/bin/gcloud. Its timeout, bucket target, output handling, and pass/fail behavior are unchanged.

Changes

GCS preflight

Layer / File(s) Summary
Use the absolute gcloud path
tasks/acs-ci-nightly/workflow/preflight.yaml
The GCS check resolves gcloud through /opt/google-cloud-sdk/bin/gcloud. The 30-second timeout and remaining arguments are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f58a6

The preflight command now uses the pinned absolute gcloud path while preserving its existing behavior, so it is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: using an absolute gcloud path in ACS CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@robbycochran
robbycochran merged commit 9768290 into main Sep 17, 2026
13 checks passed
@robbycochran
robbycochran deleted the codex/acs-gcloud-absolute branch September 17, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stackrox-ai-review Opt in to StackRox AI review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant