-
Notifications
You must be signed in to change notification settings - Fork 2
refactor(acs-ci): keep GCS collection in ACS repo #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
f58a6e3
fix(acs-ci): use absolute gcloud path
robbycochran 235a584
fix(acs-ci): pass provider token to gcloud
robbycochran 78b76ab
fix(acs-ci): avoid workflow interpolation in token check
robbycochran 5cc6dc4
docs(acs-ci): describe bounded GCS discovery
robbycochran 0d494ef
feat(acs-ci): configure triage lookback window
robbycochran 5bc1a4f
test(acs-ci): probe nightly GCS objects in preflight
robbycochran 7fb8943
fix(acs-ci): avoid workflow interpolation in probe
robbycochran 4e03525
test(acs-ci): probe GCS objects with JSON API
robbycochran 90482c4
fix(acs-ci): read nightly build results from GCS
robbycochran 627bbdb
fix(acs-ci): use direct GCS object endpoint
robbycochran 0afa08e
cleanup(acs-ci): remove temporary object probe
robbycochran ec68895
fix(acs-ci): remove obsolete write permission
robbycochran 54d0593
fix(acs-ci): configure gcloud storage auth once
robbycochran 373442e
chore(acs-ci): keep default triage window
robbycochran 1b8efb6
docs(acs-ci): use gcloud for nightly discovery
robbycochran 09fd43b
docs(acs-ci): document bounded job discovery
robbycochran e3ea815
fix(acs-ci): add trusted gsutil compatibility wrapper
robbycochran e6de088
fix(acs-ci): export gsutil shim to agent shells
robbycochran c9621f8
fix(acs-ci): resolve latest build in GCS wrapper
robbycochran 6838280
fix(acs-ci): precompute authoritative failure manifest
robbycochran a814c38
fix(acs-ci): avoid payload variable interpolation
robbycochran 14af438
fix(acs-ci): handle first GCS listing page
robbycochran 4d62c9b
fix(acs-ci): build manifest from public GCS API
robbycochran 18c19a5
chore(acs-ci): capture manifest diagnostics
robbycochran 9ce1bd6
fix(acs-ci): stage manifest diagnostics under sandbox
robbycochran 09d8405
fix(acs-ci): select latest completed build
robbycochran 56a997d
fix(acs-ci): use anonymous access for public GCS manifest
robbycochran c76497d
debug(acs-ci): record GCS list response shape
robbycochran b7abece
debug(acs-ci): inspect nested GCS listings
robbycochran 778f1f8
fix(acs-ci): use GCS media download endpoint
robbycochran 305bc28
fix(acs-ci): read GCS results from public object URLs
robbycochran 340b128
fix(acs-ci): read results with gcloud storage
robbycochran 0caa1c9
debug(acs-ci): bound GCS result reads
robbycochran bd166d7
fix(acs-ci): mark manifest rows as failures
robbycochran a900cf1
chore(acs-ci): remove temporary manifest diagnostics
robbycochran 738941d
fix(acs-ci): read GCS artifacts through public API
robbycochran 6e06f9c
fix(acs-ci): harden GCS compatibility reads
robbycochran c9c7ee1
fix(acs-ci): avoid workflow interpolation in preflight check
robbycochran 0e06c99
fix(acs-ci): validate GCS wrapper paths
robbycochran e9f5abf
chore(acs-ci): remove preflight workflow
robbycochran 996837b
fix(acs-ci): harden wrapper path validation
robbycochran 6e225a2
Merge remote-tracking branch 'origin/main' into codex/acs-gcloud-abso…
robbycochran 1c34e8f
refactor(acs-ci): keep GCS collection in ACS repo
robbycochran 8f6c077
feat(acs-ci): run canonical triage flow in sandbox
robbycochran cb1e518
fix(acs-ci): avoid reserved OpenShell environment prefix
robbycochran 6afa804
refactor(acs-ci): remove redundant task marker
robbycochran d8d0d5b
Merge remote-tracking branch 'origin/main' into codex/acs-collector-i…
robbycochran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
tasks/acs-ci-nightly/openshell/providers/github-triage-read.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Endpointless read-only GitHub profile for ACS triage. | ||
| # The provider instance is gateway-owned; no token belongs in this repository. | ||
| id: github-triage-read | ||
| display_name: GitHub ACS triage read-only | ||
| description: Gateway-managed GitHub credential for read-only project and issue queries | ||
| category: source_control | ||
| credentials: | ||
| - name: api_token | ||
| description: Gateway-managed GitHub token | ||
| env_vars: [GITHUB_TOKEN, GH_TOKEN] | ||
| required: true | ||
| auth_style: bearer | ||
| header_name: authorization | ||
| discovery: | ||
| credentials: [api_token] | ||
| binaries: | ||
| - /usr/bin/gh | ||
| - /usr/bin/curl | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This provider allows both
ghandcurlto use the GitHub token. While the network policy restricts operations toGET, allowingcurlgives more freedom than justgh. If the intention is to only allowghto use this token for triage, consider removingcurlfrom the list of binaries to reduce the attack surface.