register_pairs - #222
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new bulk-registration API on TriMap (register_pairs) to efficiently register arbitrary (src, dst) locator pairs from NumPy arrays, primarily to support many-to-many join-like mappings without per-element Python overhead.
Changes:
- Adds
TriMap.register_pairs()in the C extension, exposing it via the method table. - Adds comprehensive Python tests covering many-to-many behavior, fill/unmatched rows, and error cases.
- Updates the public type stub (
.pyi) and the changelog section inREADME.rst.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/tri_map.c |
Implements TriMap_register_pairs() and registers it as a Python-exposed method. |
test/test_tri_map.py |
Adds unit tests for register_pairs behavior and validation. |
src/__init__.pyi |
Exposes the new method in the public typing surface. |
README.rst |
Notes the addition of TriMap.register_pairs() under the 1.10.0 “What is New” section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.