test: migrate math/base/special/trigamma to ULP-based testing - #13666
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/trigamma(test.jsandtest.native.js) from relative tolerance testing to ULP difference testing using@stdlib/assert/is-almost-same-value.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Implementation Note on ULP Tolerances:
When initially testing with a
1 ULPtolerance across all test loops, 251 out of 4,105 test cases failed (2 cases in the positive number loop and 249 cases in the negative number loop).Because
trigammarelies on rational Chebyshev approximations and asymptotic expansions—particularly in negative regions where reflection formulas are evaluated—slight rounding differences naturally accumulate. To strictly adhere to Instruction #4 of RFC #11352 ("Make sure that you put the minimum required ULP value possible"), the tolerances were set to:2ULPs for positive numbers (positive.jsonfixture)3ULPs for negative numbers (negative.jsonfixture)These bounds represent the exact mathematical floor required to achieve a 100% pass rate (4,105 / 4,105 passing) while keeping the accuracy budget as tight as possible.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers