test: migrate math/base/special/fresnels to ULP-based testing - #13667
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/fresnels(test.jsandtest.native.js) from relative tolerance testing to ULP difference testing using@stdlib/assert/is-almost-same-value.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Implementation Note on ULP Tolerances:
When evaluating the 4 test loops against their corresponding C++ fixtures, the minimum required ULP tolerances were determined as follows per Instruction #4 of RFC #11352 ("Make sure that you put the minimum required ULP value possible"):
small.json(small positive values): Set to4ULPs. Near zero, polynomial approximation rounding accumulates up to a 4 ULP gap from the reference fixture (at 1 ULP -> 25 fail; at 2 ULPs -> 8 fail; at 3 ULPs -> 2 fail; at 4 ULPs -> 0 fail).medium.json,large.json, andhuge.json: Set to1ULP, achieving a 100% pass rate at the standard baseline tolerance.These bounds represent the exact mathematical floor required to achieve a 100% pass rate (4,505 / 4,505 passing) across all test suites.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers